From: mauke <lukasmai.403@gmail.com>
Date: Thu, 30 Jan 2025 05:28:50 +0000 (+0100)
Subject: runtests.pl: fix precedence issue
X-Git-Tag: curl-8_12_0~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bfec1d7165cac54af43c493d0904cbfd3d0c4f12;p=thirdparty%2Fcurl.git

runtests.pl: fix precedence issue

The condition `!$cmdtype eq "perl"` (introduced in a4765b0551) is always
false. It checks whether a logical negation (giving true/false) is equal
to the string `"perl"`. This is impossible, so the logging never worked.

The intent was probably to negate the result of the string
comparison:`!($cmdtype eq "perl")` or simply `$cmdtype ne "perl"`.

Fixes #16128
Reported-by: Igor Todorovski
Closes #16129
---

diff --git a/tests/runtests.pl b/tests/runtests.pl
index e28fd56e50..0ca69fec4c 100755
--- a/tests/runtests.pl
+++ b/tests/runtests.pl
@@ -1672,7 +1672,7 @@ sub singletest_check {
             my %cmdhash = getpartattr("client", "command");
             my $cmdtype = $cmdhash{'type'} || "default";
             logmsg "\n** ALERT! memory tracking with no output file?\n"
-                if(!$cmdtype eq "perl");
+                if($cmdtype ne "perl");
             $ok .= "-"; # problem with memory checking
         }
         else {