From: Philippe Antoine <contact@catenacyber.fr>
Date: Tue, 6 Oct 2020 11:46:47 +0000 (+0200)
Subject: dnp3: fix probing test not using final null in string
X-Git-Tag: suricata-5.0.4~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c03c8738b4258aeef7a8264e878b49bb19e5dd1e;p=thirdparty%2Fsuricata.git

dnp3: fix probing test not using final null in string
---

diff --git a/src/app-layer-dnp3.c b/src/app-layer-dnp3.c
index 0145214b28..f5b42cc1af 100644
--- a/src/app-layer-dnp3.c
+++ b/src/app-layer-dnp3.c
@@ -2102,7 +2102,7 @@ static int DNP3ProbingParserTest(void)
 
     /* Send a banner. */
     char mybanner[] = "Welcome to DNP3 SCADA.";
-    FAIL_IF(DNP3ProbingParser(NULL, STREAM_TOSERVER, (uint8_t *)mybanner, sizeof(mybanner), &rdir) != ALPROTO_DNP3);
+    FAIL_IF(DNP3ProbingParser(NULL, STREAM_TOSERVER, (uint8_t *)mybanner, sizeof(mybanner) - 1, &rdir) != ALPROTO_DNP3);
 
     PASS;
 }