From: Miek Gieben Date: Thu, 8 Sep 2005 12:08:28 +0000 (+0000) Subject: more cleanup, all XXX are gone X-Git-Tag: release-1.0.0~186 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c04d75ea5e77b8d083a977aaf349baec41b0a049;p=thirdparty%2Fldns.git more cleanup, all XXX are gone --- diff --git a/resolver.c b/resolver.c index 15c954c1..649bdf62 100644 --- a/resolver.c +++ b/resolver.c @@ -545,7 +545,6 @@ ldns_resolver_new_frm_fp_l(FILE *fp, int *line_nr) expect = LDNS_RESOLV_KEYWORD; break; } - /* XXX */ (void)ldns_resolver_push_nameserver(r, tmp); ldns_rdf_deep_free(tmp); expect = LDNS_RESOLV_KEYWORD; diff --git a/rr.c b/rr.c index beed23a7..419473a6 100644 --- a/rr.c +++ b/rr.c @@ -1676,7 +1676,7 @@ size_t ldns_rr_descriptor_maximum(const ldns_rr_descriptor *descriptor) { if (descriptor->_variable != LDNS_RDF_TYPE_NONE) { - /* XXX: Should really be SIZE_MAX... bad FreeBSD. */ + /* Should really be SIZE_MAX... bad FreeBSD. */ return UINT_MAX; } else { return descriptor->_maximum; diff --git a/rr_functions.c b/rr_functions.c index a3511247..de4d3065 100644 --- a/rr_functions.c +++ b/rr_functions.c @@ -8,8 +8,9 @@ */ /* - * these come strait from perldoc Net::DNS::RR::xxxx - * first the read variant, then the write + * These come strait from perldoc Net::DNS::RR::xxx + * first the read variant, then the write. This is + * not complete. */ #include @@ -59,8 +60,6 @@ ldns_rr_set_function(ldns_rr_type type, ldns_rr *rr, ldns_rdf *rdf, size_t pos) } } -/* all function below call the above defined ones */ - /* A/AAAA records */ ldns_rdf * ldns_rr_a_address(ldns_rr *r) @@ -72,11 +71,7 @@ ldns_rr_a_address(ldns_rr *r) } return ldns_rr_rdf(r, 0); } -/* / A-AAAA records */ -/* write - - * if there is a value in the rr - is is _freed_! - */ bool ldns_rr_a_set_address(ldns_rr *r, ldns_rdf *f) { @@ -94,6 +89,7 @@ ldns_rr_a_set_address(ldns_rr *r, ldns_rdf *f) return false; } } +/* / A-AAAA records */ /* NS record */ ldns_rdf *