From: Aleš Mrázek <ales.mrazek@nic.cz>
Date: Fri, 4 Aug 2023 13:52:28 +0000 (+0200)
Subject: utils: modeling: proper error for default creation
X-Git-Tag: v6.0.2~8^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c052bd58c185f670b6fdf71f773696d84c69f531;p=thirdparty%2Fknot-resolver.git

utils: modeling: proper error for default creation
---

diff --git a/manager/knot_resolver_manager/utils/modeling/base_schema.py b/manager/knot_resolver_manager/utils/modeling/base_schema.py
index 1bada9bce..14c97d2f9 100644
--- a/manager/knot_resolver_manager/utils/modeling/base_schema.py
+++ b/manager/knot_resolver_manager/utils/modeling/base_schema.py
@@ -515,7 +515,12 @@ class ObjectMapper:
 
     def _assign_default(self, obj: Any, name: str, python_type: Any, object_path: str) -> None:
         cls = obj.__class__
-        default = self._create_default(getattr(cls, name, None))
+
+        try:
+            default = self._create_default(getattr(cls, name, None))
+        except ValueError as e:
+            raise DataValidationError(str(e), f"{object_path}/{name}")
+
         value = self.map_object(python_type, default, object_path=f"{object_path}/{name}")
         setattr(obj, name, value)