From: Jeff Trawick <trawick@apache.org>
Date: Mon, 5 May 2008 14:28:10 +0000 (+0000)
Subject: bogus concern answered by Eric
X-Git-Tag: 2.2.9~227
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c06d9414d9e36101c5e171762e01da65e4f4d5d3;p=thirdparty%2Fapache%2Fhttpd.git

bogus concern answered by Eric


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@653492 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index bc5b572e410..5768119874a 100644
--- a/STATUS
+++ b/STATUS
@@ -96,6 +96,15 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
          http://people.apache.org/~covener/2.2.x-proxy-status_t.diff 
     +1 covener, niq, trawick
 
+ * mod_ldap: Correctly return all requested attribute values
+   when some attributes have a null value.
+   PR: 44560
+   Trunk version of patch:
+       http://svn.apache.org/viewvc?rev=634821&view=rev
+   Backport version for 2.2.x of patch:
+       http://people.apache.org/~covener/2.2.x-pr44560.diff
+   +1 covener, niq, trawick
+
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]
 
@@ -196,32 +205,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
       http://people.apache.org/~jim/patches/proxy-ssl-44026-patch.txt
    +1: jim, rpluem
 
- * mod_ldap: Correctly return all requested attribute values
-   when some attributes have a null value.
-   PR: 44560
-   Trunk version of patch:
-       http://svn.apache.org/viewvc?rev=634821&view=rev
-   Backport version for 2.2.x of patch:
-       http://people.apache.org/~covener/2.2.x-pr44560.diff
-   +1 covener, niq
-   trawick: I don't understand the API for the affected array.
-     Consider uldap_cache_getuserdn():  
-     Before this change, we returned a new list of ptrs to strings,
-     with a NULL ptr signifying the end of the list.  (Yes, we messed
-     up and could miss some of the strings.)
-     After this change, we return a new list of ptrs to strings,
-     of indeterminate length since NULL pointers are scattered 
-     through the array.  So how does the caller know how to walk
-     through the list? (It seems that we need need to allocate numvals+1,
-     then store in (*retvals)[j++] when vals[i] != NULL.)
-   covener: The caller has asked for values corresponding to a passed list 
-     of attributes (attrs), so the returned list does not need to be null 
-     terminated (or otherwise convey a length)
-     mod_authnz_ldap iterates through it's own copy of the _attributes_ 
-     (null terminated, like the native LDAP API) and uses the 
-     correspondingly-indexed entry in the returned values 
-     (retvals in uldap_cache_getuserdn() signature)
-
  * mod_headers: Add merge option to avoid duplicate values within
    the same header.
    Trunk version of patch: