From: Pami Ketolainen <pami.ketolainen@jollamobile.com>
Date: Thu, 18 Sep 2014 09:08:07 +0000 (+0800)
Subject: Bug 1068521: "Use of uninitialized value" warnings
X-Git-Tag: bugzilla-4.5.6~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c07333d9c122bd6751e31dae5a7c49901f6518b2;p=thirdparty%2Fbugzilla.git

Bug 1068521: "Use of uninitialized value" warnings
r=glob,a=glob
---

diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index 79e3e053b4..18181f489c 100644
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -373,10 +373,7 @@ sub param {
         if (!scalar(@result)
             && $self->request_method && $self->request_method eq 'POST')
         {
-            # Some servers fail to set the QUERY_STRING parameter, which
-            # causes undef issues
-            $ENV{'QUERY_STRING'} = '' unless exists $ENV{'QUERY_STRING'};
-            @result = $self->SUPER::url_param(@_);
+            @result = $self->url_param(@_);
         }
 
         # Fix UTF-8-ness of input parameters.
@@ -401,6 +398,14 @@ sub param {
     return $self->SUPER::param(@_);
 }
 
+sub url_param {
+    my $self = shift;
+    # Some servers fail to set the QUERY_STRING parameter, which
+    # causes undef issues
+    $ENV{'QUERY_STRING'} //= '';
+    return $self->SUPER::url_param(@_);
+}
+
 sub _fix_utf8 {
     my $input = shift;
     # The is_utf8 is here in case CGI gets smart about utf8 someday.
@@ -732,6 +737,8 @@ L<CGI|CGI>, L<CGI::Cookie|CGI::Cookie>
 
 =item param
 
+=item url_param
+
 =item header
 
 =back
diff --git a/process_bug.cgi b/process_bug.cgi
index 4b35bf432b..b47a3b1cfc 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -234,7 +234,7 @@ if (should_set('keywords')) {
 }
 if (should_set('comment')) {
     my $is_markdown = ($user->settings->{use_markdown}->{is_enabled} &&
-                            $cgi->param('use_markdown') eq '1') ? 1 : 0;
+                            $cgi->param('use_markdown')) ? 1 : 0;
 
     $set_all_fields{comment} = {
         body        => scalar $cgi->param('comment'),