From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 17 Aug 2023 23:48:03 +0000 (+1200)
Subject: tests/krb5: Match filter after transforming test name
X-Git-Tag: tevent-0.16.0~390
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0795c807a06c8213e4836f36e6c8d7a41b677f4;p=thirdparty%2Fsamba.git

tests/krb5: Match filter after transforming test name

If you just want to rerun a single test that failed, this removes the
need to successfully guess its untransformed name.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/claims_tests.py b/python/samba/tests/krb5/claims_tests.py
index 8df4595079d..348ea99ec0d 100755
--- a/python/samba/tests/krb5/claims_tests.py
+++ b/python/samba/tests/krb5/claims_tests.py
@@ -721,9 +721,9 @@ class ClaimsTests(KDCBaseTest):
         FILTER = env_get_var_value('FILTER', allow_missing=True)
         for case in cls.cases:
             name = case.pop('name')
+            name = re.sub(r'\W+', '_', name)
             if FILTER and not re.search(FILTER, name):
                 continue
-            name = re.sub(r'\W+', '_', name)
 
             # Run tests making requests both to the krbtgt and to our own
             # account.
@@ -734,9 +734,9 @@ class ClaimsTests(KDCBaseTest):
 
         for case in cls.device_claims_cases:
             name = case.pop('test')
+            name = re.sub(r'\W+', '_', name)
             if FILTER and not re.search(FILTER, name):
                 continue
-            name = re.sub(r'\W+', '_', name)
 
             cls.generate_dynamic_test('test_device_claims', name,
                                       dict(case))
diff --git a/python/samba/tests/krb5/device_tests.py b/python/samba/tests/krb5/device_tests.py
index a1997ecb966..87b65735a03 100755
--- a/python/samba/tests/krb5/device_tests.py
+++ b/python/samba/tests/krb5/device_tests.py
@@ -1795,9 +1795,9 @@ class DeviceTests(KDCBaseTest):
                 # be skipped.
                 continue
             name = case.pop('test')
+            name = re.sub(r'\W+', '_', name)
             if FILTER and not re.search(FILTER, name):
                 continue
-            name = re.sub(r'\W+', '_', name)
 
             cls.generate_dynamic_test('test_device_info', name,
                                       dict(case))
diff --git a/python/samba/tests/krb5/group_tests.py b/python/samba/tests/krb5/group_tests.py
index 4d43ec4217f..1214fa2bd88 100755
--- a/python/samba/tests/krb5/group_tests.py
+++ b/python/samba/tests/krb5/group_tests.py
@@ -76,9 +76,9 @@ class GroupTests(KDCBaseTest):
                 # be skipped.
                 continue
             name = case.pop('test')
+            name = re.sub(r'\W+', '_', name)
             if FILTER and not re.search(FILTER, name):
                 continue
-            name = re.sub(r'\W+', '_', name)
 
             cls.generate_dynamic_test('test_group', name,
                                       dict(case))