From: skyler-ferrante <sjf5462@rit.edu>
Date: Wed, 22 Mar 2023 16:46:56 +0000 (-0400)
Subject: Fix null dereference in basename
X-Git-Tag: 4.14.0-rc1~131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c089196e15dcafc186474469c4914638da233b31;p=thirdparty%2Fshadow.git

Fix null dereference in basename

On older kernels (<=linux-5.17), argv[0] can be null. Basename would
call strrchr with null if argc==0. Fixes issue #680
---

diff --git a/libmisc/basename.c b/libmisc/basename.c
index fe9165322..95a2f85dd 100644
--- a/libmisc/basename.c
+++ b/libmisc/basename.c
@@ -21,6 +21,10 @@
 #include "prototypes.h"
 /*@observer@*/const char *Basename (const char *str)
 {
+	if (str == NULL) {
+		abort ();
+	}
+
 	char *cp = strrchr (str, '/');
 
 	return (NULL != cp) ? cp + 1 : str;