From: Tobias Brunner <tobias@strongswan.org>
Date: Tue, 18 Apr 2023 14:42:30 +0000 (+0200)
Subject: x509: Fix build with DEBUG_LEVEL < 2 for structures that ignore unknown critical... 
X-Git-Tag: 5.9.11rc1~12^2~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0a281472f8e6bc7c39fef1656e0da23450e1fb7;p=thirdparty%2Fstrongswan.git

x509: Fix build with DEBUG_LEVEL < 2 for structures that ignore unknown critical extensions
---

diff --git a/src/libstrongswan/plugins/x509/x509_ac.c b/src/libstrongswan/plugins/x509/x509_ac.c
index c4acce4fee..2e370f5a71 100644
--- a/src/libstrongswan/plugins/x509/x509_ac.c
+++ b/src/libstrongswan/plugins/x509/x509_ac.c
@@ -429,7 +429,6 @@ static bool parse_certificate(private_x509_ac_t *this)
 	int extn_oid = OID_UNKNOWN;
 	signature_params_t sig_alg = {};
 	bool success = FALSE;
-	bool critical;
 
 	parser = asn1_parser_create(acObjects, this->encoding);
 
@@ -529,8 +528,8 @@ static bool parse_certificate(private_x509_ac_t *this)
 				extn_oid = asn1_known_oid(object);
 				break;
 			case AC_OBJ_CRITICAL:
-				critical = object.len && *object.ptr;
-				DBG2(DBG_ASN, "  %s",(critical)?"TRUE":"FALSE");
+				DBG2(DBG_ASN, "  %s",
+					 object.len && *object.ptr ? "TRUE" : "FALSE");
 				break;
 			case AC_OBJ_EXTN_VALUE:
 			{
diff --git a/src/libstrongswan/plugins/x509/x509_ocsp_response.c b/src/libstrongswan/plugins/x509/x509_ocsp_response.c
index 93fbc81738..9954e55ce9 100644
--- a/src/libstrongswan/plugins/x509/x509_ocsp_response.c
+++ b/src/libstrongswan/plugins/x509/x509_ocsp_response.c
@@ -528,7 +528,6 @@ static bool parse_basicOCSPResponse(private_x509_ocsp_response_t *this,
 	u_int responses_level = level0;
 	certificate_t *cert;
 	bool success = FALSE;
-	bool critical;
 
 	parser = asn1_parser_create(basicResponseObjects, blob);
 	parser->set_top_level(parser, level0);
@@ -573,8 +572,8 @@ static bool parse_basicOCSPResponse(private_x509_ocsp_response_t *this,
 				extn_oid = asn1_known_oid(object);
 				break;
 			case BASIC_RESPONSE_CRITICAL:
-				critical = object.len && *object.ptr;
-				DBG2(DBG_ASN, "  %s", critical ? "TRUE" : "FALSE");
+				DBG2(DBG_ASN, "  %s",
+					 object.len && *object.ptr ? "TRUE" : "FALSE");
 				break;
 			case BASIC_RESPONSE_EXT_VALUE:
 				if (extn_oid == OID_NONCE &&
diff --git a/src/libstrongswan/plugins/x509/x509_pkcs10.c b/src/libstrongswan/plugins/x509/x509_pkcs10.c
index 94a90ebf09..dcf431ea83 100644
--- a/src/libstrongswan/plugins/x509/x509_pkcs10.c
+++ b/src/libstrongswan/plugins/x509/x509_pkcs10.c
@@ -430,7 +430,6 @@ static bool parse_extension_request(private_x509_pkcs10_t *this, chunk_t blob, i
 	int objectID;
 	int extn_oid = OID_UNKNOWN;
 	bool success = FALSE;
-	bool critical;
 
 	parser = asn1_parser_create(extensionRequestObjects, blob);
 	parser->set_top_level(parser, level0);
@@ -445,8 +444,8 @@ static bool parse_extension_request(private_x509_pkcs10_t *this, chunk_t blob, i
 				extn_oid = asn1_known_oid(object);
 				break;
 			case PKCS10_EXTN_CRITICAL:
-				critical = object.len && *object.ptr;
-				DBG2(DBG_ASN, "  %s", critical ? "TRUE" : "FALSE");
+				DBG2(DBG_ASN, "  %s",
+					 object.len && *object.ptr ? "TRUE" : "FALSE");
 				break;
 			case PKCS10_EXTN_VALUE:
 			{