From: Mark Michelson Date: Thu, 30 Oct 2008 19:23:16 +0000 (+0000) Subject: I just noticed this construct and thought it was X-Git-Tag: 1.6.2.0-beta1~1005 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0b9b259ca1b9121dab8210188a33933a5f9bede;p=thirdparty%2Fasterisk.git I just noticed this construct and thought it was silly to have a bunch of case statements with duplicated code in each case. Instead, just use the built-in fallthrough capability of case statements and reduce the code to a single instance git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152879 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 03eb7530c6..d66ba78169 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -16604,18 +16604,9 @@ static void handle_response(struct sip_pvt *p, int resp, char *rest, struct sip_ switch(resp) { case 100: /* 100 Trying */ case 101: /* 101 Dialog establishment */ - if (sipmethod == SIP_INVITE) - handle_response_invite(p, resp, rest, req, seqno); - break; case 183: /* 183 Session Progress */ - if (sipmethod == SIP_INVITE) - handle_response_invite(p, resp, rest, req, seqno); - break; case 180: /* 180 Ringing */ - if (sipmethod == SIP_INVITE) - handle_response_invite(p, resp, rest, req, seqno); - break; - case 182: /* 182 Queued */ + case 182: /* 182 Queued */ if (sipmethod == SIP_INVITE) handle_response_invite(p, resp, rest, req, seqno); break;