From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 17 Jan 2019 17:15:37 +0000 (+0100)
Subject: sd-bus: make sure dispatch_rqueue() initializes return parameter on all types of... 
X-Git-Tag: v242-rc1~215^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0bc4ec5cc17ac61773d1e9362b0ffa8382c1ff1;p=thirdparty%2Fsystemd.git

sd-bus: make sure dispatch_rqueue() initializes return parameter on all types of success

Let's make sure our own code follows coding style and initializes all
return values on all types of success (and leaves it uninitialized in
all types of failure).
---

diff --git a/src/libsystemd/sd-bus/sd-bus.c b/src/libsystemd/sd-bus/sd-bus.c
index f000c6250bd..933a5c594eb 100644
--- a/src/libsystemd/sd-bus/sd-bus.c
+++ b/src/libsystemd/sd-bus/sd-bus.c
@@ -1865,8 +1865,10 @@ static int dispatch_rqueue(sd_bus *bus, bool hint_priority, int64_t priority, sd
                 r = bus_read_message(bus, hint_priority, priority);
                 if (r < 0)
                         return r;
-                if (r == 0)
+                if (r == 0) {
+                        *m = NULL;
                         return ret;
+                }
 
                 ret = 1;
         }