From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 09:43:16 +0000 (+0200) Subject: memory: tegra30-emc: Do not print error on icc_node_create() failure X-Git-Tag: v6.19-rc1~98^2~14^2~10 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0ca941c93527a9e96f3ba58c0970cdf94670203;p=thirdparty%2Flinux.git memory: tegra30-emc: Do not print error on icc_node_create() failure icc_node_create() isĀ alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Reviewed-by: Jon Hunter Signed-off-by: Krzysztof Kozlowski --- diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c index 921dce1b8bc63..c96aa63a5aa08 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1534,10 +1534,8 @@ static int tegra_emc_interconnect_init(struct tegra_emc *emc) /* create External Memory Controller node */ node = icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err = PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); node->name = "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1565,7 +1563,6 @@ static int tegra_emc_interconnect_init(struct tegra_emc *emc) remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); return err;