From: Kruti <kpendharkar@vmware.com>
Date: Mon, 19 Feb 2024 14:32:44 +0000 (-0800)
Subject: Fix out-of-bound access issues reported by Coverity
X-Git-Tag: stable-12.4.0~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0cc78a3fa53c8f6ea82aafda981251e753bae4d;p=thirdparty%2Fopen-vm-tools.git

Fix out-of-bound access issues reported by Coverity

Do not pass PATH_MAX and FILENAME_MAX to Str_Strlen function call.
---

diff --git a/open-vm-tools/libDeployPkg/linuxDeploymentUtilities.c b/open-vm-tools/libDeployPkg/linuxDeploymentUtilities.c
index 61ccd54d3..9b36168b6 100644
--- a/open-vm-tools/libDeployPkg/linuxDeploymentUtilities.c
+++ b/open-vm-tools/libDeployPkg/linuxDeploymentUtilities.c
@@ -82,8 +82,9 @@ IsCloudInitCustomizationEnabled()
          cloudInitConfigDirPath, strerror(errno));
    } else {
       for (i = fileCount - 1; i >= 0; i--) {
-         filePathLength = Str_Strlen(cloudInitConfigDirPath, PATH_MAX) +
-            Str_Strlen(fileList[i]->d_name, FILENAME_MAX) + 1;
+         filePathLength =
+            Str_Strlen(cloudInitConfigDirPath, sizeof(cloudInitConfigDirPath))
+            + Str_Strlen(fileList[i]->d_name, NAME_MAX) + 1;
          filePath = malloc(filePathLength);
          if (filePath == NULL) {
             sLog(log_warning, "Error allocating memory to copy '%s'.",