From: Paul Floyd Date: Tue, 23 Jun 2026 06:55:37 +0000 (+0200) Subject: Regtest: fix build of none crc32 x86 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0efe57f42aef9fb1119cc7b80966bca34f75724;p=thirdparty%2Fvalgrind.git Regtest: fix build of none crc32 x86 The 32bit opcode variant needs an explicit l suffix for clang. The test is still failing due the the flags mask/printf. With clang, in gdb jusrt before the crc32 opcode rthe flags are eflags 0x200296 [ PF AF SF IF ID ] but with gcc eflags 0x200202 [ IF ID ] AF and SF need to be masked. It seems to work without masking PF, not sure why, need to look at that a bit more. --- diff --git a/none/tests/x86/crc32.c b/none/tests/x86/crc32.c index f5e2a561e..1bfcd26ef 100644 --- a/none/tests/x86/crc32.c +++ b/none/tests/x86/crc32.c @@ -313,7 +313,7 @@ void test_CRC32_U32_x86 ( void ) __asm__ __volatile__( "movl %0, %%eax" "\n\t" "movl 4(%%eax), %%ecx" "\n\t" - "crc32 0(%%eax), %%ecx" "\n\t" + "crc32l 0(%%eax), %%ecx" "\n\t" "movl %%ecx, 8(%%eax)" "\n\t" "pushf" "\n\t" "popl %%edx" "\n\t"