From: Mats Klepsland Date: Mon, 26 Sep 2016 13:53:48 +0000 (+0200) Subject: util-decode-der-get: fix coverity warning X-Git-Tag: suricata-3.2beta1~275 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0f93503b76b4b567b64fe7c8d7220a85a0f1770;p=thirdparty%2Fsuricata.git util-decode-der-get: fix coverity warning *** CID 1373380: Control flow issues (DEADCODE) /src/util-decode-der-get.c: 126 in UtctimeToTime() 120 year = strtol(yy, NULL, 10); 121 if (year >= 50) 122 snprintf(buf, sizeof(buf), "%i%s", 19, utctime); 123 else if (year < 50) 124 snprintf(buf, sizeof(buf), "%i%s", 20, utctime); 125 else >>> CID 1373380: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "goto error;". 126 goto error; 127 128 time = GentimeToTime(buf); 129 if (time == -1) 130 goto error; 131 --- diff --git a/src/util-decode-der-get.c b/src/util-decode-der-get.c index 413c431581..747bf4b422 100644 --- a/src/util-decode-der-get.c +++ b/src/util-decode-der-get.c @@ -120,10 +120,8 @@ static time_t UtctimeToTime(char *utctime) year = strtol(yy, NULL, 10); if (year >= 50) snprintf(buf, sizeof(buf), "%i%s", 19, utctime); - else if (year < 50) - snprintf(buf, sizeof(buf), "%i%s", 20, utctime); else - goto error; + snprintf(buf, sizeof(buf), "%i%s", 20, utctime); time = GentimeToTime(buf); if (time == -1)