From: Laine Stump <laine@redhat.com>
Date: Mon, 23 Nov 2020 14:48:29 +0000 (-0500)
Subject: network: be more verbose about the reason for a firewall reload
X-Git-Tag: v6.10.0-rc1~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c102bbd3efc358fb44fa2bb37fb0bcbeaaab72a5;p=thirdparty%2Flibvirt.git

network: be more verbose about the reason for a firewall reload

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 5d9b9eaa4f..fdad2191e6 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -653,6 +653,7 @@ firewalld_dbus_signal_callback(GDBusConnection *connection G_GNUC_UNUSED,
     if (STREQ(interfaceName, "org.fedoraproject.FirewallD1") &&
         STREQ(signalName, "Reloaded")) {
         reload = true;
+        VIR_DEBUG("Reload in bridge_driver because of 'Reloaded' signal");
     } else if (STREQ(interfaceName, "org.freedesktop.DBus") &&
                STREQ(signalName, "NameOwnerChanged")) {
         char *name = NULL;
@@ -661,14 +662,15 @@ firewalld_dbus_signal_callback(GDBusConnection *connection G_GNUC_UNUSED,
 
         g_variant_get(parameters, "(&s&s&s)", &name, &old_owner, &new_owner);
 
-        if (new_owner && *new_owner)
+        if (new_owner && *new_owner) {
+            VIR_DEBUG("Reload in bridge_driver because of 'NameOwnerChanged' signal, new owner is: '%s'",
+                      new_owner);
             reload = true;
+        }
     }
 
-    if (reload) {
-        VIR_DEBUG("Reload in bridge_driver because of firewalld.");
+    if (reload)
         networkReloadFirewallRules(driver, false, true);
-    }
 }
 #endif