From: Dmitry Belyavskiy <beldmit@gmail.com>
Date: Wed, 19 Feb 2025 14:27:57 +0000 (+0100)
Subject: Fix coverity finding
X-Git-Tag: openssl-3.5.0-alpha1~135
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c152a943957933e8aa621441a36e9951f7eff050;p=thirdparty%2Fopenssl.git

Fix coverity finding

Coverity ID: 1643094

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26831)
---

diff --git a/crypto/evp/skeymgmt_meth.c b/crypto/evp/skeymgmt_meth.c
index 67d6ea3446a..10a320e58a6 100644
--- a/crypto/evp/skeymgmt_meth.c
+++ b/crypto/evp/skeymgmt_meth.c
@@ -116,8 +116,13 @@ static void *skeymgmt_from_algorithm(int name_id,
         ERR_raise(ERR_LIB_EVP, EVP_R_INVALID_PROVIDER_FUNCTIONS);
         return NULL;
     }
+
+    if (!ossl_provider_up_ref(prov)) {
+        EVP_SKEYMGMT_free(skeymgmt);
+        ERR_raise(ERR_LIB_EVP, EVP_R_INITIALIZATION_ERROR);
+        return NULL;
+    }
     skeymgmt->prov = prov;
-    ossl_provider_up_ref(prov);
 
     return skeymgmt;
 }