From: Nick Porter <nick@portercomputing.co.uk>
Date: Thu, 13 Apr 2023 16:19:14 +0000 (+0100)
Subject: Free redis result on failure paths
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c168d0a69e6750066f3175537ab69fd7def9dcdf;p=thirdparty%2Ffreeradius-server.git

Free redis result on failure paths
---

diff --git a/src/modules/rlm_redis/rlm_redis.c b/src/modules/rlm_redis/rlm_redis.c
index 3ac92c2150..d9bea2dfde 100644
--- a/src/modules/rlm_redis/rlm_redis.c
+++ b/src/modules/rlm_redis/rlm_redis.c
@@ -510,7 +510,8 @@ static xlat_action_t redis_lua_func_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 	MEM(vb_out = fr_value_box_alloc_null(ctx));
 	if (fr_redis_reply_to_value_box(ctx, vb_out, reply, FR_TYPE_VOID, NULL, false, false) < 0) {
 		RPERROR("Failed processing reply");
-		return XLAT_ACTION_FAIL;
+		action = XLAT_ACTION_FAIL;
+		goto finish;
 	}
 	fr_dcursor_append(out, vb_out);
 
@@ -719,7 +720,8 @@ reply_parse:
 	MEM(vb_out = fr_value_box_alloc_null(ctx));
 	if (fr_redis_reply_to_value_box(ctx, vb_out, reply, FR_TYPE_VOID, NULL, false, false) < 0) {
 		RPERROR("Failed processing reply");
-		return XLAT_ACTION_FAIL;
+		action = XLAT_ACTION_FAIL;
+		goto finish;
 	}
 	fr_dcursor_append(out, vb_out);