From: Greg Hudson <ghudson@mit.edu>
Date: Thu, 25 Feb 2016 16:27:40 +0000 (-0500)
Subject: Fix KDC memory leak on failed S4U2Proxy requests
X-Git-Tag: kfw-4.1-beta3-mit~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c16a6bb0de6b09319d8bb80b04c5bf87b31798f2;p=thirdparty%2Fkrb5.git

Fix KDC memory leak on failed S4U2Proxy requests

Make sure to release stkt_server in process_tgs_req() if we fail
before its disposition is determined.  Reported by Will Fiveash.

(back ported from commit 194641a8ad7aecc6bc1d4848742c14569f14b900)

ticket: 8363
version_fixed: 1.13.5
status: resolved
tags: -pullup
---

diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index 48e822b103..bb0797887b 100644
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -849,6 +849,7 @@ cleanup:
         kdc_free_rstate(state);
     krb5_db_free_principal(kdc_context, server);
     krb5_db_free_principal(kdc_context, krbtgt);
+    krb5_db_free_principal(kdc_context, stkt_server);
     krb5_db_free_principal(kdc_context, client);
     if (session_key.contents != NULL)
         krb5_free_keyblock_contents(kdc_context, &session_key);