From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 27 May 2021 09:42:19 +0000 (+0200)
Subject: virCapabilitiesHostNUMAInitReal: Don't jump over cleanup
X-Git-Tag: v7.4.0-rc2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1715890893bea856a27411fe6ba23b73be3b4f1;p=thirdparty%2Flibvirt.git

virCapabilitiesHostNUMAInitReal: Don't jump over cleanup

In one of my recent commits I've done some renaming. But whilst
doing so I also mistakenly replaced 'goto cleanup' with 'return
-1' in virCapabilitiesHostNUMAInitReal() which was incorrect.

Fixes: fe25224fdaa53bbeceed3ddeef1b3a150665e656
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index 1290c9c15d..2f9a1e7d1f 100644
--- a/src/conf/capabilities.c
+++ b/src/conf/capabilities.c
@@ -1623,7 +1623,7 @@ virCapabilitiesHostNUMAInitReal(virCapsHostNUMA *caps)
         }
 
         if (virCapabilitiesGetNUMADistances(n, &distances, &ndistances) < 0)
-            return -1;
+            goto cleanup;
 
         if (virCapabilitiesGetNUMAPagesInfo(n, &pageinfo, &npageinfo) < 0)
             goto cleanup;