From: Francis Dupont <fdupont@isc.org>
Date: Wed, 8 Jul 2015 13:45:22 +0000 (+0200)
Subject: [3932] Ignored remove return status
X-Git-Tag: trac4006_base~23^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c18a6bcf2c91c1113a8b26b684dc316d2a2e233d;p=thirdparty%2Fkea.git

[3932] Ignored remove return status
---

diff --git a/src/lib/config/command_socket_factory.cc b/src/lib/config/command_socket_factory.cc
index bc4448be25..aa3cbe520e 100644
--- a/src/lib/config/command_socket_factory.cc
+++ b/src/lib/config/command_socket_factory.cc
@@ -83,7 +83,7 @@ private:
         // Let's remove the old file. We don't care about any possible
         // errors here. The file should not be there if the file was
         // shut down properly.
-        remove(file_name.c_str());
+        static_cast<void>(remove(file_name.c_str()));
 
         // Set this socket to be non-blocking one.
         if (fcntl(fd, F_SETFL, O_NONBLOCK) !=0 ) {
@@ -100,7 +100,7 @@ private:
         if (bind(fd, (struct sockaddr*)&addr, sizeof(addr))) {
             const char* errmsg = strerror(errno);
             ::close(fd);
-            remove(file_name.c_str());
+            static_cast<void>(remove(file_name.c_str()));
             isc_throw(isc::config::SocketError, "Failed to bind socket " << fd
                       << " to " << file_name << ": " << errmsg);
         }
@@ -114,7 +114,7 @@ private:
         if (status < 0) {
             const char* errmsg = strerror(errno);
             ::close(fd);
-            remove(file_name.c_str());
+            static_cast<void>(remove(file_name.c_str()));
             isc_throw(isc::config::SocketError, "Failed to listen on socket fd="
                       << fd << ", filename=" << file_name << ": " << errmsg);
         }
@@ -181,7 +181,7 @@ private:
         // Close should always succeed. We don't care if we're able to delete
         // the socket or not.
         ::close(sockfd_);
-        remove(filename_.c_str());
+        static_cast<void>(remove(filename_.c_str()));
     }
 
     /// @brief UNIX filename representing this socket
diff --git a/src/lib/dhcp/tests/iface_mgr_unittest.cc b/src/lib/dhcp/tests/iface_mgr_unittest.cc
index e3771c6f54..ff8bb068bc 100644
--- a/src/lib/dhcp/tests/iface_mgr_unittest.cc
+++ b/src/lib/dhcp/tests/iface_mgr_unittest.cc
@@ -478,7 +478,7 @@ TEST_F(IfaceMgrTest, dhcp6Sniffer) {
     // Testing socket operation in a portable way is tricky
     // without interface detection implemented
 
-    remove("interfaces.txt");
+    static_cast<void>(remove("interfaces.txt"));
 
     ofstream interfaces("interfaces.txt", ios::ate);
     interfaces << "eth0 fe80::21e:8cff:fe9b:7349";