From: Peter Astrand <astrand@lysator.liu.se>
Date: Thu, 21 Oct 2004 19:28:34 +0000 (+0000)
Subject: Removed test_close_fds, because it's too unreliable. We simply cannot
X-Git-Tag: v2.4b2~70
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c19ccc9f1137bceb830a635a199b0798cc6d3932;p=thirdparty%2FPython%2Fcpython.git

Removed test_close_fds, because it's too unreliable. We simply cannot
know that the newly-started Python process only has 3 filedescriptors
open. Fixes bug 1048808.
---

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 639a54d9b510..a5d9d9c59f33 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -421,16 +421,6 @@ class ProcessTestCase(unittest.TestCase):
                              preexec_fn=lambda: os.putenv("FRUIT", "apple"))
             self.assertEqual(p.stdout.read(), "apple")
 
-        def test_close_fds(self):
-            # Make sure we have some fds open
-            os.pipe()
-            p = subprocess.Popen([sys.executable, "-c",
-                              'import sys,os;' \
-                              'sys.stdout.write(str(os.dup(0)))'],
-                             stdout=subprocess.PIPE, close_fds=1)
-            # When all fds are closed, the next free fd should be 3.
-            self.assertEqual(p.stdout.read(), "3")
-
         def test_args_string(self):
             # args is a string
             f, fname = self.mkstemp()