From: Andrei Pavel <andrei@isc.org>
Date: Wed, 19 Apr 2023 19:06:36 +0000 (+0300)
Subject: [#549] address review comments
X-Git-Tag: Kea-2.3.7~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1bc73e9cfaceec3f9cb6c00730ec13693982936;p=thirdparty%2Fkea.git

[#549] address review comments
---

diff --git a/src/hooks/dhcp/lease_cmds/lease_cmds.h b/src/hooks/dhcp/lease_cmds/lease_cmds.h
index 0a4f386ddd..1ea9e534de 100644
--- a/src/hooks/dhcp/lease_cmds/lease_cmds.h
+++ b/src/hooks/dhcp/lease_cmds/lease_cmds.h
@@ -1,4 +1,4 @@
-// Copyright (C) 2017-2022 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2017-2023 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
diff --git a/src/lib/cc/command_interpreter.cc b/src/lib/cc/command_interpreter.cc
index c5b478dd5e..92cf76dd6c 100644
--- a/src/lib/cc/command_interpreter.cc
+++ b/src/lib/cc/command_interpreter.cc
@@ -174,7 +174,7 @@ parseCommand(ConstElementPtr& arg, ConstElementPtr command) {
     }
     if (command->getType() != Element::map) {
         isc_throw(CtrlChannelError, "invalid command: expected toplevel entry to be a map, got "
-                                        << Element::typeToName(command->getType()) << " instead");
+                  << Element::typeToName(command->getType()) << " instead");
     }
     if (!command->contains(CONTROL_COMMAND)) {
         isc_throw(CtrlChannelError,
@@ -196,8 +196,8 @@ parseCommand(ConstElementPtr& arg, ConstElementPtr command) {
     ConstElementPtr cmd = command->get(CONTROL_COMMAND);
     if (cmd->getType() != Element::string) {
         isc_throw(CtrlChannelError, "invalid command: expected '"
-                                        << CONTROL_COMMAND << "' to be a string, got "
-                                        << Element::typeToName(command->getType()) << " instead");
+                  << CONTROL_COMMAND << "' to be a string, got "
+                  << Element::typeToName(command->getType()) << " instead");
     }
 
     arg = command->get(CONTROL_ARGUMENTS);
@@ -282,5 +282,5 @@ combineCommandsLists(const ConstElementPtr& response1,
     }
 }
 
-}
-}
+}  // namespace config
+}  // namespace isc
diff --git a/src/lib/dhcpsrv/pgsql_host_data_source.h b/src/lib/dhcpsrv/pgsql_host_data_source.h
index be342e7a91..37b8e5f62b 100644
--- a/src/lib/dhcpsrv/pgsql_host_data_source.h
+++ b/src/lib/dhcpsrv/pgsql_host_data_source.h
@@ -559,7 +559,7 @@ private:
     PgSqlHostDataSourceImplPtr impl_;
 };
 
-}
-}
+}  // namespace dhcp
+}  // namespace isc
 
 #endif // PGSQL_HOST_DATA_SOURCE_H
diff --git a/src/lib/dhcpsrv/tests/host_cache_unittest.cc b/src/lib/dhcpsrv/tests/host_cache_unittest.cc
index 516c0f4e99..4665a92e4f 100644
--- a/src/lib/dhcpsrv/tests/host_cache_unittest.cc
+++ b/src/lib/dhcpsrv/tests/host_cache_unittest.cc
@@ -698,9 +698,6 @@ public:
         return (false);
     }
 
-    void update(HostPtr const&) {
-    }
-
     std::string getType() const {
         return ("one");
     }
@@ -996,4 +993,4 @@ TEST_F(NegativeCacheTest, get6withNegativeCaching) {
     testGet6();
 }
 
-}; // end of anonymous namespace
+}  // namespace
diff --git a/src/share/api/reservation-add.json b/src/share/api/reservation-add.json
index ecee118bc5..d771725613 100644
--- a/src/share/api/reservation-add.json
+++ b/src/share/api/reservation-add.json
@@ -5,7 +5,7 @@
         "This command adds a new host reservation. The reservation may include IPv4 addresses, IPv6 addresses, IPv6 prefixes, various identifiers, a class the client will be assigned to, DHCPv4 and DHCPv6 options, and more."
     ],
     "cmd-comment": [
-        "Note that ip-address, client-id, next-server, server-hostname, and boot-file-name are IPv4-specific. ip-addresses, and prefixes are IPv6-specific."
+        "Note that boot-file-name, circuit-id, client-id, ip-address, next-server, and server-hostname are IPv4-specific. ip-addresses, and prefixes are IPv6-specific."
     ],
     "cmd-syntax": [
         "{",
diff --git a/src/share/api/reservation-update.json b/src/share/api/reservation-update.json
index 5c0a0b81b1..7af996b6fb 100644
--- a/src/share/api/reservation-update.json
+++ b/src/share/api/reservation-update.json
@@ -5,7 +5,7 @@
         "This command updates an existing host reservation. The reservation has to include host identifiers and a subnet identifier and may include IPv4 addresses, IPv6 addresses, IPv6 prefixes, various identifiers, a class the client will be assigned to, DHCPv4 and DHCPv6 options, and more."
     ],
     "cmd-comment": [
-        "Note that ip-address, client-id, next-server, server-hostname, and boot-file-name are IPv4-specific. ip-addresses, and prefixes are IPv6-specific."
+        "Note that boot-file-name, circuit-id, client-id, ip-address, next-server, and server-hostname are IPv4-specific. ip-addresses, and prefixes are IPv6-specific."
     ],
     "cmd-syntax": [
         "{",