From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 15 May 2024 21:24:20 +0000 (-0600)
Subject: Remove all the module_rlm_by_data lookup functions
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1c814327d6874c8660e0af55fdedd1d20580df4;p=thirdparty%2Ffreeradius-server.git

Remove all the module_rlm_by_data lookup functions
---

diff --git a/src/lib/server/module_rlm.c b/src/lib/server/module_rlm.c
index 66e5e2e1db1..2d67bde3f31 100644
--- a/src/lib/server/module_rlm.c
+++ b/src/lib/server/module_rlm.c
@@ -803,11 +803,6 @@ module_instance_t *module_rlm_by_name(module_instance_t const *parent, char cons
 	return module_instance_by_name(rlm_modules_static, parent, asked_name);
 }
 
-module_instance_t *module_rlm_by_data(module_instance_t const *data)
-{
-	return module_instance_by_data(rlm_modules_static, data);
-}
-
 /** Create a virtual module.
  *
  * @param[in] cs	that defines the virtual module.
diff --git a/src/lib/server/module_rlm.h b/src/lib/server/module_rlm.h
index 0cb00f71f57..7332ea3e2f3 100644
--- a/src/lib/server/module_rlm.h
+++ b/src/lib/server/module_rlm.h
@@ -98,8 +98,6 @@ module_thread_instance_t *module_rlm_thread_by_data(void const *data);
 
 module_instance_t	*module_rlm_by_name(module_instance_t const *parent, char const *asked_name);
 
-module_instance_t	*module_rlm_by_data(module_instance_t const *data);
-
 CONF_SECTION		*module_rlm_by_name_virtual(char const *asked_name);
 
 /** @} */
diff --git a/src/modules/rlm_mschap/rlm_mschap.c b/src/modules/rlm_mschap/rlm_mschap.c
index 395224e61ff..f480d9a5712 100644
--- a/src/modules/rlm_mschap/rlm_mschap.c
+++ b/src/modules/rlm_mschap/rlm_mschap.c
@@ -795,10 +795,9 @@ static int _mod_conn_free(struct wbcContext **wb_ctx)
 /*
  *	Create connection pool winbind context
  */
-static void *mod_conn_create(TALLOC_CTX *ctx, void *instance, UNUSED fr_time_delta_t timeout)
+static void *mod_conn_create(TALLOC_CTX *ctx, UNUSED void *instance, UNUSED fr_time_delta_t timeout)
 {
 	struct wbcContext	**wb_ctx;
-	module_inst_ctx_t	*mctx =  MODULE_INST_CTX(module_rlm_by_data(instance));
 
 	wb_ctx = talloc_zero(ctx, struct wbcContext *);
 	*wb_ctx = wbcCtxCreate();