From: Paul Floyd <pjfloyd@wanadoo.fr>
Date: Sat, 18 Nov 2023 07:23:08 +0000 (+0100)
Subject: freebsd: unused variable warning
X-Git-Tag: VALGRIND_3_23_0~261
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1cc1f4b5e77d0598bec6e91dc34775ce25e7ef5;p=thirdparty%2Fvalgrind.git

freebsd: unused variable warning

still not sure what to do in aio_cancel
---

diff --git a/coregrind/m_syswrap/syswrap-freebsd.c b/coregrind/m_syswrap/syswrap-freebsd.c
index dab12a6eac..9371fed0f1 100644
--- a/coregrind/m_syswrap/syswrap-freebsd.c
+++ b/coregrind/m_syswrap/syswrap-freebsd.c
@@ -3012,14 +3012,17 @@ PRE(sys_aio_cancel)
    } else {
       if (ARG2) {
          if (ML_(safe_to_deref)((struct vki_aiocb *)ARG2, sizeof(struct vki_aiocb))) {
-            struct vki_aiocb *iocb = (struct vki_aiocb *)ARG2;
+            // struct vki_aiocb *iocb = (struct vki_aiocb *)ARG2;
             // @todo PJF cancel only requests associated with
             // fildes and iocb
+            // Do I need to remove pending reads from iocb(v)_table
+            // or should the user always call aio_return even after
+            // aio_cancel?
          } else {
             SET_STATUS_Failure(VKI_EINVAL);
          }
       } else {
-         // @todo PJF cancel all requests associated with fildes
+         // @todo PJF cancel all requests associated with fildes, see above
       }
    }
 }