From: Victor Julien <victor@inliniac.net>
Date: Tue, 31 Jul 2018 07:14:26 +0000 (+0200)
Subject: detect/parse: improve direction setting on sigs
X-Git-Tag: suricata-5.0.0-beta1~138
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1dcc2696536e29d134601828a70d71a0aa6f5bc;p=thirdparty%2Fsuricata.git

detect/parse: improve direction setting on sigs

Only set both directions if no direction has been explicitly set before.
---

diff --git a/src/detect-parse.c b/src/detect-parse.c
index 7760826962..cbc57576b4 100644
--- a/src/detect-parse.c
+++ b/src/detect-parse.c
@@ -1835,8 +1835,10 @@ static Signature *SigInitHelper(DetectEngineCtx *de_ctx, const char *sigstr,
     }
 
     if (!(sig->init_data->init_flags & SIG_FLAG_INIT_FLOW)) {
-        sig->flags |= SIG_FLAG_TOSERVER;
-        sig->flags |= SIG_FLAG_TOCLIENT;
+        if ((sig->flags & (SIG_FLAG_TOSERVER|SIG_FLAG_TOCLIENT)) == 0) {
+            sig->flags |= SIG_FLAG_TOSERVER;
+            sig->flags |= SIG_FLAG_TOCLIENT;
+        }
     }
 
     SCLogDebug("sig %"PRIu32" SIG_FLAG_APPLAYER: %s, SIG_FLAG_PACKET: %s",