From: Philippe Antoine <pantoine@oisf.net>
Date: Fri, 27 Jan 2023 12:28:57 +0000 (+0100)
Subject: src: fix coverity warning about sizeof
X-Git-Tag: suricata-7.0.0-rc1~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1f615b8d24b2363a08cc171d2f401adbf2f4ae7;p=thirdparty%2Fsuricata.git

src: fix coverity warning about sizeof

CID: 1520601
CID: 1520602

> In this particular case sizeof (char **) happens to be equal to
sizeof (char *), but this is not a portable assumption.
---

diff --git a/src/suricata.c b/src/suricata.c
index ad44e129aa..6a655a1e85 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -1772,7 +1772,7 @@ static TmEcode ParseCommandLine(int argc, char** argv, SCInstance *suri)
                 }
             } else if (strcmp((long_opts[option_index]).name, "include") == 0) {
                 if (suri->additional_configs == NULL) {
-                    suri->additional_configs = SCCalloc(2, sizeof(char **));
+                    suri->additional_configs = SCCalloc(2, sizeof(char *));
                     if (suri->additional_configs == NULL) {
                         FatalError(
                                 "Failed to allocate memory for additional configuration files: %s",
@@ -1783,7 +1783,7 @@ static TmEcode ParseCommandLine(int argc, char** argv, SCInstance *suri)
                     for (int i = 0;; i++) {
                         if (suri->additional_configs[i] == NULL) {
                             const char **additional_configs =
-                                    SCRealloc(suri->additional_configs, (i + 2) * sizeof(char **));
+                                    SCRealloc(suri->additional_configs, (i + 2) * sizeof(char *));
                             if (additional_configs == NULL) {
                                 FatalError("Failed to allocate memory for additional configuration "
                                            "files: %s",