From: Aleš Mrázek <ales.mrazek@nic.cz>
Date: Fri, 28 Feb 2025 09:14:22 +0000 (+0100)
Subject: datamodel: management: warning that the unix-socket is not located in rundir
X-Git-Tag: v6.0.12~12^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1f8f7bc043ca31b9aac96c13411769fad17f6b2;p=thirdparty%2Fknot-resolver.git

datamodel: management: warning that the unix-socket is not located in rundir
---

diff --git a/python/knot_resolver/datamodel/config_schema.py b/python/knot_resolver/datamodel/config_schema.py
index 410e94d7c..713c4a3e2 100644
--- a/python/knot_resolver/datamodel/config_schema.py
+++ b/python/knot_resolver/datamodel/config_schema.py
@@ -184,6 +184,14 @@ class KresConfig(ConfigSchema):
         return obj.dns64
 
     def _validate(self) -> None:
+        # warn about '/management/unix-socket' not located in '/rundir'
+        if self.management.unix_socket and self.management.unix_socket.to_path().parent != self.rundir.to_path():
+            logger.warning(
+                f"The management API unix-socket '{self.management.unix_socket}'"
+                f" is not located in the resolver's rundir '{self.rundir}'."
+                " This can lead to permissions issues."
+            )
+
         # enforce max-workers config
         workers_max = _workers_max_count()
         if int(self.workers) > workers_max: