From: Joseph Sutton Date: Mon, 7 Nov 2022 01:14:18 +0000 (+1300) Subject: s4: Add 'const' to some parameters X-Git-Tag: talloc-2.4.1~1672 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c21d5bf6740d246a5d887f696f21940cf7cf4079;p=thirdparty%2Fsamba.git s4: Add 'const' to some parameters Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/source4/auth/auth.h b/source4/auth/auth.h index 6b7db99cbe2..c03eba4ca67 100644 --- a/source4/auth/auth.h +++ b/source4/auth/auth.h @@ -121,7 +121,7 @@ NTSTATUS authsam_make_user_info_dc(TALLOC_CTX *mem_ctx, struct ldb_context *sam_ const char *domain_name, const char *dns_domain_name, struct ldb_dn *domain_dn, - struct ldb_message *msg, + const struct ldb_message *msg, DATA_BLOB user_sess_key, DATA_BLOB lm_sess_key, struct auth_user_info_dc **_user_info_dc); NTSTATUS authsam_update_user_info_dc(TALLOC_CTX *mem_ctx, diff --git a/source4/auth/sam.c b/source4/auth/sam.c index ca26898f4ce..609d83e1420 100644 --- a/source4/auth/sam.c +++ b/source4/auth/sam.c @@ -337,7 +337,7 @@ _PUBLIC_ NTSTATUS authsam_make_user_info_dc(TALLOC_CTX *mem_ctx, const char *domain_name, const char *dns_domain_name, struct ldb_dn *domain_dn, - struct ldb_message *msg, + const struct ldb_message *msg, DATA_BLOB user_sess_key, DATA_BLOB lm_sess_key, struct auth_user_info_dc **_user_info_dc) diff --git a/source4/dsdb/common/rodc_helper.c b/source4/dsdb/common/rodc_helper.c index 2448de13201..d1fd2dbfb80 100644 --- a/source4/dsdb/common/rodc_helper.c +++ b/source4/dsdb/common/rodc_helper.c @@ -96,7 +96,7 @@ static WERROR samdb_result_sid_array_ndr(struct ldb_context *sam_ctx, assumes the SIDs are in extended DN format */ WERROR samdb_result_sid_array_dn(struct ldb_context *sam_ctx, - struct ldb_message *msg, + const struct ldb_message *msg, TALLOC_CTX *mem_ctx, const char *attr, uint32_t *num_sids, @@ -132,10 +132,10 @@ WERROR samdb_result_sid_array_dn(struct ldb_context *sam_ctx, WERROR samdb_confirm_rodc_allowed_to_repl_to_sid_list(struct ldb_context *sam_ctx, const struct dom_sid *rodc_machine_account_sid, - struct ldb_message *rodc_msg, - struct ldb_message *obj_msg, + const struct ldb_message *rodc_msg, + const struct ldb_message *obj_msg, uint32_t num_token_sids, - struct dom_sid *token_sids) + const struct dom_sid *token_sids) { uint32_t num_never_reveal_sids, num_reveal_sids; struct dom_sid *never_reveal_sids, *reveal_sids; diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c index 2c4bc980f80..25681f8b4a6 100644 --- a/source4/dsdb/common/util.c +++ b/source4/dsdb/common/util.c @@ -488,7 +488,7 @@ NTTIME samdb_result_account_expires(const struct ldb_message *msg) NTTIME samdb_result_allow_password_change(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struct ldb_dn *domain_dn, - struct ldb_message *msg, + const struct ldb_message *msg, const char *attr) { uint64_t attr_time = ldb_msg_find_attr_as_uint64(msg, attr, 0); diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c index 6418b1220ed..0707f0a68b3 100644 --- a/source4/kdc/db-glue.c +++ b/source4/kdc/db-glue.c @@ -3264,7 +3264,7 @@ krb5_error_code samba_kdc_check_s4u2proxy_rbcd( struct samba_kdc_db_context *kdc_db_ctx, krb5_const_principal client_principal, krb5_const_principal server_principal, - krb5_pac header_pac, + krb5_const_pac header_pac, struct samba_kdc_entry *proxy_skdc_entry) { krb5_error_code code; diff --git a/source4/kdc/db-glue.h b/source4/kdc/db-glue.h index 3a59d6a421a..f37e6e96731 100644 --- a/source4/kdc/db-glue.h +++ b/source4/kdc/db-glue.h @@ -95,7 +95,7 @@ krb5_error_code samba_kdc_check_s4u2proxy_rbcd( struct samba_kdc_db_context *kdc_db_ctx, krb5_const_principal client_principal, krb5_const_principal server_principal, - krb5_pac header_pac, + krb5_const_pac header_pac, struct samba_kdc_entry *proxy_skdc_entry); NTSTATUS samba_kdc_setup_db_ctx(TALLOC_CTX *mem_ctx, struct samba_kdc_base_context *base_ctx, diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c index 395bd7c0d56..bc5408fefb3 100644 --- a/source4/kdc/pac-glue.c +++ b/source4/kdc/pac-glue.c @@ -819,7 +819,7 @@ static NTSTATUS samba_add_asserted_identity(TALLOC_CTX *mem_ctx, * reused on future calls to this function. */ NTSTATUS samba_kdc_get_user_info_from_db(struct samba_kdc_entry *skdc_entry, - struct ldb_message *msg, + const struct ldb_message *msg, struct auth_user_info_dc **user_info_dc) { if (skdc_entry->user_info_dc == NULL) { @@ -1302,9 +1302,9 @@ out: * be replicated to the KDC (krbgtgt_xxx user) represented by *rodc */ WERROR samba_rodc_confirm_user_is_allowed(uint32_t num_object_sids, - struct dom_sid *object_sids, - struct samba_kdc_entry *rodc, - struct samba_kdc_entry *object) + const struct dom_sid *object_sids, + const struct samba_kdc_entry *rodc, + const struct samba_kdc_entry *object) { int ret; WERROR werr; diff --git a/source4/kdc/pac-glue.h b/source4/kdc/pac-glue.h index 6a1de6dda17..9aca42f641b 100644 --- a/source4/kdc/pac-glue.h +++ b/source4/kdc/pac-glue.h @@ -67,7 +67,7 @@ int samba_krbtgt_is_in_db(struct samba_kdc_entry *skdc_entry, bool *is_untrusted); NTSTATUS samba_kdc_get_user_info_from_db(struct samba_kdc_entry *skdc_entry, - struct ldb_message *msg, + const struct ldb_message *msg, struct auth_user_info_dc **user_info_dc); NTSTATUS samba_kdc_get_pac_blobs(TALLOC_CTX *mem_ctx, @@ -113,9 +113,9 @@ krb5_error_code samba_kdc_validate_pac_blob( * be replicated to the KDC (krbgtgt_xxx user) represented by *rodc */ WERROR samba_rodc_confirm_user_is_allowed(uint32_t num_sids, - struct dom_sid *sids, - struct samba_kdc_entry *rodc, - struct samba_kdc_entry *object); + const struct dom_sid *object_sids, + const struct samba_kdc_entry *rodc, + const struct samba_kdc_entry *object); krb5_error_code samba_kdc_update_pac(TALLOC_CTX *mem_ctx, krb5_context context,