From: John Wolfe <jwolfe@vmware.com>
Date: Fri, 31 Jul 2020 20:36:34 +0000 (-0700)
Subject: [Coverity] Remove superfluous condition in if statement
X-Git-Tag: stable-11.2.0~107
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c275d66d52a532ddae5ca0bfe4b1af7f71209524;p=thirdparty%2Fopen-vm-tools.git

[Coverity] Remove superfluous condition in if statement
---

diff --git a/open-vm-tools/services/plugins/serviceDiscovery/serviceDiscoveryPosix.c b/open-vm-tools/services/plugins/serviceDiscovery/serviceDiscoveryPosix.c
index c3c2b83bd..1220948b0 100644
--- a/open-vm-tools/services/plugins/serviceDiscovery/serviceDiscoveryPosix.c
+++ b/open-vm-tools/services/plugins/serviceDiscovery/serviceDiscoveryPosix.c
@@ -194,7 +194,7 @@ out:
          g_warning("%s: Failed to close child stdout file stream, errno=%d",
                    __FUNCTION__, errno);
       }
-   } else if (child_stdout != -1 && close(child_stdout) != 0) {
+   } else if (close(child_stdout) != 0) {
       g_warning("%s: Failed to close child stdout handle, errno=%d",
                 __FUNCTION__, errno);
    }