From: lpsolit%gmail.com <>
Date: Sat, 4 Nov 2006 08:31:03 +0000 (+0000)
Subject: Bug 258675: action=view is still used in comments - Patch by Frédéric Buclin <LpSol... 
X-Git-Tag: bugzilla-2.23.4~231
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c27a4c99e0b0d27737bd50c08ca1c16ed3a29242;p=thirdparty%2Fbugzilla.git

Bug 258675: action=view is still used in comments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
---

diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm
index 915e3cdc6b..ed6880b017 100644
--- a/Bugzilla/Template.pm
+++ b/Bugzilla/Template.pm
@@ -383,11 +383,11 @@ sub get_attachment_link {
         $title = value_quote($title);
 
         $link_text =~ s/ \[details\]$//;
-        my $linkval = "attachment.cgi?id=$attachid&amp;action=";
+        my $linkval = "attachment.cgi?id=$attachid";
         # Whitespace matters here because these links are in <pre> tags.
         return qq|<span class="$className">|
-               . qq|<a href="${linkval}view" title="$title">$link_text</a>|
-               . qq| <a href="${linkval}edit" title="$title">[details]</a>|
+               . qq|<a href="${linkval}" title="$title">$link_text</a>|
+               . qq| <a href="${linkval}&amp;action=edit" title="$title">[details]</a>|
                . qq|</span>|;
     }
     else {