From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Tue, 8 Jul 2025 16:51:17 +0000 (+0100)
Subject: net: Incorrect NOP macro used for test
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c29c5ed2966425a14aab6794e739a78ab46178a5;p=thirdparty%2Fu-boot.git

net: Incorrect NOP macro used for test

In tcp_parse_options the uchar p[0] is attempted to test for a match
with the 32bit macro TCP_0_NOP which can never be true. Instead test
against the 8bit macro TCP_1_NOP.

This issue found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
---

diff --git a/net/tcp.c b/net/tcp.c
index 2635727f47d..8740150365f 100644
--- a/net/tcp.c
+++ b/net/tcp.c
@@ -804,7 +804,7 @@ void tcp_parse_options(struct tcp_stream *tcp, uchar *o, int o_len)
 		}
 
 		/* Process optional NOPs */
-		if (p[0] == TCP_O_NOP)
+		if (p[0] == TCP_1_NOP)
 			p++;
 		else
 			p += p[1];