From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 22 Oct 2014 23:12:17 +0000 (-0400)
Subject: - sketch of how "batch operations" would work
X-Git-Tag: rel_0_7_0~57
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c2a91ac4d2cec85325d46d04a290c61578f465b6;p=thirdparty%2Fsqlalchemy%2Falembic.git

- sketch of how "batch operations" would work
---

diff --git a/alembic/batch.py b/alembic/batch.py
new file mode 100644
index 00000000..96e12f43
--- /dev/null
+++ b/alembic/batch.py
@@ -0,0 +1,125 @@
+class BatchOperationsImpl(object):
+    def __init__(self, operations, table_name, recreate):
+        self.operations = operations
+        self.table_name = table_name
+        self.recreate = recreate
+        self.batch = []
+
+    def flush(self):
+        should_recreate = self.recreate is True or \
+            self.operations.impl.__dialect__ in set(self.recreate)
+
+        if not should_recreate:
+            for opname, arg, kw in self.batch:
+                fn = getattr(self.operations.impl, opname)
+                fn(*arg, **kw)
+        else:
+            # pseudocode
+            existing_table = _reflect_table(self.operations.impl, table_name)
+            impl = ApplyBatchImpl(existing_table)
+            for opname, arg, kw in self.batch:
+                fn = getattr(impl, opname)
+                fn(*arg, **kw)
+
+            _create_new_table(use_a_temp_name)
+            _copy_data_somehow(
+                impl.use_column_transfer_data, use_insert_from_select_aswell)
+            _drop_old_table(this_parts_easy)
+            _rename_table_to_old_name(ditto)
+
+    def alter_column(self, *arg, **kw):
+        self.batch.append(
+            ("alter_column", arg, kw)
+        )
+
+    def add_column(self, *arg, **kw):
+        self.batch.append(
+            ("add_column", arg, kw)
+        )
+
+    def drop_column(self, *arg, **kw):
+        self.batch.append(
+            ("drop_column", arg, kw)
+        )
+
+    def add_constraint(self, const):
+        self.batch.append(
+            ("add_constraint", (const,), {})
+        )
+
+    def drop_constraint(self, const):
+        self.batch.append(
+            ("drop_constraint", (const, ), {})
+        )
+
+    def rename_table(self, *arg, **kw):
+        self.batch.append(
+            ("rename_table", arg, kw)
+        )
+
+    def create_table(self, table):
+        raise NotImplementedError("Can't create table in batch mode")
+
+    def drop_table(self, table):
+        raise NotImplementedError("Can't drop table in batch mode")
+
+    def create_index(self, index):
+        raise NotImplementedError("Can't create index in batch mode")
+
+    def drop_index(self, index):
+        raise NotImplementedError("Can't drop index in batch mode")
+
+
+class ApplyBatchImpl(object):
+    def __init__(self, table):
+        self.table = table  # this is a Table object
+        self.column_transfers = dict(
+            (c.name, {}) for c in self.table.c
+        )
+
+    def alter_column(self, table_name, column_name,
+                     nullable=None,
+                     server_default=False,
+                     name=None,
+                     type_=None,
+                     autoincrement=None,
+                     **kw
+                     ):
+        existing = self.table.c[column_name]
+        existing_transfer = self.column_transfers[column_name]
+        if name != column_name:
+            # something like this
+            self.table.c.remove_column(existing)
+            existing.table = None
+            existing.name = name
+            existing._set_parent(self.table)
+            existing_transfer["name"] = name
+
+        if type_ is not None:
+            existing.type = type_
+            existing_transfer["typecast"] = type_
+        if nullable is not None:
+            existing.nullable = nullable
+        if server_default is not False:
+            existing.server_default = server_default
+        if autoincrement is not None:
+            existing.autoincrement = bool(autoincrement)
+
+    def add_column(self, table_name, column, **kw):
+        column.table = None
+        column._set_parent(self.table)
+
+    def drop_column(self, table_name, column, **kw):
+        col = self.table.c[column.name]
+        col.table = None
+        self.table.c.remove_column(col)
+        del self.column_transfers[column.name]
+
+    def add_constraint(self, const):
+        raise NotImplementedError("TODO")
+
+    def drop_constraint(self, const):
+        raise NotImplementedError("TODO")
+
+    def rename_table(self, *arg, **kw):
+        raise NotImplementedError("TODO")
diff --git a/alembic/operations.py b/alembic/operations.py
index 11319f73..10032a0f 100644
--- a/alembic/operations.py
+++ b/alembic/operations.py
@@ -3,7 +3,7 @@ from contextlib import contextmanager
 from sqlalchemy.types import NULLTYPE, Integer
 from sqlalchemy import schema as sa_schema
 
-from . import util
+from . import util, batch
 from .compat import string_types
 from .ddl import impl
 
@@ -42,7 +42,7 @@ class Operations(object):
 
     """
 
-    def __init__(self, migration_context):
+    def __init__(self, migration_context, impl=None):
         """Construct a new :class:`.Operations`
 
         :param migration_context: a :class:`.MigrationContext`
@@ -50,7 +50,10 @@ class Operations(object):
 
         """
         self.migration_context = migration_context
-        self.impl = migration_context.impl
+        if impl is None:
+            self.impl = migration_context.impl
+        else:
+            self.impl = impl
 
     @classmethod
     @contextmanager
@@ -186,6 +189,13 @@ class Operations(object):
             if cname not in rel_t.c:
                 rel_t.append_column(sa_schema.Column(cname, NULLTYPE))
 
+    @contextmanager
+    def batch_alter_table(self, table_name, recreate=None):
+        impl = batch.BatchOperationImpl(self, table_name, recreate)
+        batch_op = Operations(self.migration_context, impl=impl)
+        yield batch_op
+        impl.flush()
+
     def get_context(self):
         """Return the :class:`.MigrationContext` object that's
         currently in use.