From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 6 Jun 2013 16:43:29 +0000 (-0600)
Subject: Do not log bogus ERRORs when url_rewrite_access bypasses url_rewriter.
X-Git-Tag: SQUID_3_4_0_1~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c2d5e22e1ebb856f11ea6bedf3b575a5e0e4ab96;p=thirdparty%2Fsquid.git

Do not log bogus ERRORs when url_rewrite_access bypasses url_rewriter.

The code uses HelperReply() object as a fake reply when url_rewrite_access
ACLs did not match. That fake reply had Unknown result code, which made Squid
log ERRORs to cache.log. We now use Error result code, just like
store_id_access does.

TODO: Bypass the overheads of creating and processing a fake reply by moving
all post-processing actions and checks into a new dedicated method and calling
that method when url_rewrite_access does not match. Do the same to the StoreID
code.
---

diff --git a/src/client_side_request.cc b/src/client_side_request.cc
index d3070c9a56..0b9d5cfd30 100644
--- a/src/client_side_request.cc
+++ b/src/client_side_request.cc
@@ -906,6 +906,7 @@ clientRedirectAccessCheckDone(allow_t answer, void *data)
         redirectStart(http, clientRedirectDoneWrapper, context);
     else {
         HelperReply nilReply;
+        nilReply.result = HelperReply::Error;
         context->clientRedirectDone(nilReply);
     }
 }