From: Vladimir Serbinenko <phcoder@gmail.com>
Date: Tue, 27 Jan 2015 15:48:53 +0000 (+0100)
Subject: linux/hostdisk: Limit strcpy size to buffer size.
X-Git-Tag: 2.02-beta3~466
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c2fc41990a77923c44a71d616561920ae186db56;p=thirdparty%2Fgrub.git

linux/hostdisk: Limit strcpy size to buffer size.

Found by: Coverity scan.
---

diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/hostdisk.c
index c96427a56..75cb8f55d 100644
--- a/grub-core/osdep/linux/hostdisk.c
+++ b/grub-core/osdep/linux/hostdisk.c
@@ -376,7 +376,7 @@ grub_util_fd_open_device (const grub_disk_t disk, grub_disk_addr_t sector, int f
 
     part_start = grub_partition_get_start (disk->partition);
 
-    strcpy (dev, grub_util_biosdisk_get_osdev (disk));
+    strlcpy (dev, grub_util_biosdisk_get_osdev (disk), sizeof (dev));
     if (disk->partition
 	&& strncmp (dev, "/dev/", 5) == 0)
       {
@@ -439,7 +439,7 @@ grub_util_fd_open_device (const grub_disk_t disk, grub_disk_addr_t sector, int f
 	    if (*max == 0)
 	      *max = ~0ULL;
 	    is_partition = 0;
-	    strcpy (dev, grub_util_biosdisk_get_osdev (disk));
+	    strlcpy (dev, grub_util_biosdisk_get_osdev (disk), sizeof (dev));
 	    goto reopen;
 	  }
 	sector -= part_start;