From: Nick Porter <nick@portercomputing.co.uk>
Date: Thu, 17 Aug 2023 17:13:12 +0000 (+0100)
Subject: Revert "Remove closed connections from the parent's tracking list"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c32355be2f32306bed0a828f41298b5f988d7012;p=thirdparty%2Ffreeradius-server.git

Revert "Remove closed connections from the parent's tracking list"

This reverts commit bac1129ed8dab05a976fd97cbcd6df98276104ff.
---

diff --git a/src/lib/io/master.c b/src/lib/io/master.c
index b17942d4999..6ea24d45d2c 100644
--- a/src/lib/io/master.c
+++ b/src/lib/io/master.c
@@ -2574,7 +2574,6 @@ static int mod_close(fr_listen_t *li)
 	fr_io_instance_t const *inst;
 	fr_io_connection_t *connection;
 	fr_listen_t *child;
-	fr_io_client_t *parent;
 
 	get_inst(li, &inst, NULL, &connection, &child);
 
@@ -2598,15 +2597,6 @@ static int mod_close(fr_listen_t *li)
 	if (connection->client->pending) {
 		TALLOC_FREE(connection->client->pending); /* for any pending packets */
 	}
-
-	/*
-	 *	Remove the connection from the parent's connection set
-	 */
-	parent = connection->parent;
-	pthread_mutex_lock(&parent->mutex);
-	fr_hash_table_remove(parent->ht, connection);
-	pthread_mutex_unlock(&parent->mutex);
-
 	talloc_free(connection->dl_inst);
 
 	return 0;