From: Xiao Ni <xni@redhat.com>
Date: Fri, 8 Sep 2023 08:44:35 +0000 (+0800)
Subject: mdadm/tests: Don't run mknod before losetup
X-Git-Tag: mdadm-4.3~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c32b4754014c1eec8cc0c025fad2e9b621486164;p=thirdparty%2Fmdadm.git

mdadm/tests: Don't run mknod before losetup

Sometimes it can fail:
losetup: /var/tmp/mdtest0: failed to set up loop device: No such device or address
/dev/loop0 and /var/tmp/mdtest0 are already created before losetup.

Because losetup can create device node by itself. So remove mknod.

Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Jes Sorensen <jes@trained-monkey.org>
---

diff --git a/tests/func.sh b/tests/func.sh
index 9710a53b..5053b012 100644
--- a/tests/func.sh
+++ b/tests/func.sh
@@ -170,7 +170,6 @@ do_setup() {
 				dd if=/dev/zero of=$targetdir/mdtest$d count=$sz bs=1K > /dev/null 2>&1
 			# make sure udev doesn't touch
 			mdadm --zero $targetdir/mdtest$d 2> /dev/null
-			[ -b /dev/loop$d ] || mknod /dev/loop$d b 7 $d
 			if [ $d -eq 7 ]
 			then
 				losetup /dev/loop$d $targetdir/mdtest6 # for multipath use