From: Tim Wiederhake <twiederh@redhat.com>
Date: Wed, 21 Apr 2021 13:33:26 +0000 (+0200)
Subject: virDomainDiskSourceNVMeParse: Use virXMLProp*
X-Git-Tag: v7.3.0-rc1~88
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c348da7c4c138c108695c5f309f62e87d0101eda;p=thirdparty%2Flibvirt.git

virDomainDiskSourceNVMeParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1f68ac4dc5..d04c4e3074 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8468,7 +8468,6 @@ virDomainDiskSourceNVMeParse(xmlNodePtr node,
     g_autoptr(virStorageSourceNVMeDef) nvme = NULL;
     g_autofree char *type = NULL;
     g_autofree char *namespc = NULL;
-    g_autofree char *managed = NULL;
     xmlNodePtr address;
 
     nvme = g_new0(virStorageSourceNVMeDef, 1);
@@ -8499,16 +8498,9 @@ virDomainDiskSourceNVMeParse(xmlNodePtr node,
         return -1;
     }
 
-    if ((managed = virXMLPropString(node, "managed"))) {
-        int value;
-        if ((value = virTristateBoolTypeFromString(managed)) <= 0) {
-            virReportError(VIR_ERR_XML_ERROR,
-                           _("malformed managed value '%s'"),
-                           managed);
-            return -1;
-        }
-        nvme->managed = value;
-    }
+    if (virXMLPropTristateBool(node, "managed", VIR_XML_PROP_NONE,
+                               &nvme->managed) < 0)
+        return -1;
 
     if (!(address = virXPathNode("./address", ctxt))) {
         virReportError(VIR_ERR_XML_ERROR, "%s",