From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 11 Mar 2008 14:25:49 +0000 (+0000)
Subject: Don't force Xen connections to readonly when non-root
X-Git-Tag: LIBVIRT_0_4_2~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3501d4792efa6972b73807c40140f6cbe16739f;p=thirdparty%2Flibvirt.git

Don't force Xen connections to readonly when non-root
---

diff --git a/ChangeLog b/ChangeLog
index f294dbfbc1..d9a012e1de 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Tue Mar 11 10:21:53 EDT 2008 Daniel P. Berrange <berrange@redhat.com>
+
+	* src/virsh.c: Don't force connection to readonly as non-root
+	since with auth support we can have full connections.
+
 Tue Mar 11 10:17:53 EDT 2008 Daniel P. Berrange <berrange@redhat.com>
 
 	* qemud/qemud.c: Don't run cleanup code when parent process is
diff --git a/src/virsh.c b/src/virsh.c
index c6bac127b7..cf0f12c50e 100644
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -6045,13 +6045,6 @@ vshInit(vshControl * ctl)
     /* set up the library error handler */
     virSetErrorFunc(NULL, virshErrorHandler);
 
-#ifndef __MINGW32__
-    /* Force a non-root, Xen connection to readonly */
-    if ((ctl->name == NULL ||
-         !strcasecmp(ctl->name, "xen")) && ctl->uid != 0)
-         ctl->readonly = 1;
-#endif
-
     ctl->conn = virConnectOpenAuth(ctl->name,
                                    virConnectAuthPtrDefault,
                                    ctl->readonly ? VIR_CONNECT_RO : 0);