From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Fri, 15 Jun 2018 09:33:34 +0000 (+0200)
Subject: coverity: #1425770
X-Git-Tag: lxc-3.1.0~245^2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3b818a0b32632af43f32ed11fb89e69ace24f6f;p=thirdparty%2Flxc.git

coverity: #1425770

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 12f2cd449..7aafddaff 100644
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -2411,8 +2411,11 @@ bool lxc_nic_exists(char *nic)
 int lxc_make_tmpfile(char *template, bool rm)
 {
 	int fd, ret;
+	mode_t msk;
 
+	msk = umask(0022);
 	fd = mkstemp(template);
+	umask(msk);
 	if (fd < 0)
 		return -1;