From: Jürg Billeter <j@bitron.ch>
Date: Sun, 24 May 2009 09:42:11 +0000 (+0200)
Subject: Do not declare construct-only properties in header files
X-Git-Tag: 0.7.3~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3ca637a8c92a24e9baa2e7fa424ec2a985abe09;p=thirdparty%2Fvala.git

Do not declare construct-only properties in header files

Fixes bug 580386.
---

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index c5987eb73..4a41c666d 100644
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -1214,12 +1214,15 @@ internal class Vala.CCodeBaseModule : CCodeModule {
 		    || (prop.base_property == null && prop.base_interface_property == null)) {
 			generate_property_accessor_declaration (acc, source_declarations);
 
-			if (!prop.is_internal_symbol ()
-			    && (acc.access == SymbolAccessibility.PUBLIC
-				|| acc.access == SymbolAccessibility.PROTECTED)) {
-				generate_property_accessor_declaration (acc, header_declarations);
+			// do not declare construct-only properties in header files
+			if (acc.readable || acc.writable) {
+				if (!prop.is_internal_symbol ()
+				    && (acc.access == SymbolAccessibility.PUBLIC
+					|| acc.access == SymbolAccessibility.PROTECTED)) {
+					generate_property_accessor_declaration (acc, header_declarations);
+				}
+				generate_property_accessor_declaration (acc, internal_header_declarations);
 			}
-			generate_property_accessor_declaration (acc, internal_header_declarations);
 		}
 
 		var this_type = new ObjectType (t);