From: Richard Guenther <rguenther@suse.de>
Date: Wed, 9 Jan 2008 15:46:49 +0000 (+0000)
Subject: re PR tree-optimization/30132 (ICE in find_lattice_value, at tree-complex.c:133)
X-Git-Tag: releases/gcc-4.3.0~678
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3e203cf80e81a73402d0ae6ba9b3961394c0434;p=thirdparty%2Fgcc.git

re PR tree-optimization/30132 (ICE in find_lattice_value, at tree-complex.c:133)

2008-01-09  Richard Guenther  <rguenther@suse.de>
	Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR middle-end/30132
	* gimplify.c (gimplify_cond_expr): Do not create an addressable
	temporary if an rvalue is ok or an lvalue is not required.

	* gcc.c-torture/compile/pr30132.c: New testcase.

Co-Authored-By: Andrew Pinski <andrew_pinski@playstation.sony.com>

From-SVN: r131430
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index acfca73d9e81..bfdeb6571c0c 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2008-01-09  Richard Guenther  <rguenther@suse.de>
+	Andrew Pinski  <andrew_pinski@playstation.sony.com>
+
+	PR middle-end/30132
+	* gimplify.c (gimplify_cond_expr): Do not create an addressable
+	temporary if an rvalue is ok or an lvalue is not required.
+
 2008-01-09  Richard Guenther  <rguenther@suse.de>
 
 	PR middle-end/34458
diff --git a/gcc/gimplify.c b/gcc/gimplify.c
index dd832228f0aa..52547415c0ac 100644
--- a/gcc/gimplify.c
+++ b/gcc/gimplify.c
@@ -2633,7 +2633,11 @@ gimplify_cond_expr (tree *expr_p, tree *pre_p, fallback_t fallback)
     {
       tree result;
 
-      if ((fallback & fb_lvalue) == 0)
+      /* If an rvalue is ok or we do not require an lvalue, avoid creating
+	 an addressable temporary.  */
+      if (((fallback & fb_rvalue)
+	   || !(fallback & fb_lvalue))
+	  && !TREE_ADDRESSABLE (type))
 	{
 	  if (gimplify_ctxp->allow_rhs_cond_expr
 	      /* If either branch has side effects or could trap, it can't be
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 78f54391a06f..3201f9e50513 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2008-01-09  Richard Guenther  <rguenther@suse.de>
+	Andrew Pinski  <andrew_pinski@playstation.sony.com>
+
+	PR middle-end/30132
+	* gcc.c-torture/compile/pr30132.c: New testcase.
+
 2008-01-09  Richard Guenther  <rguenther@suse.de>
 
 	PR middle-end/34458
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr30132.c b/gcc/testsuite/gcc.c-torture/compile/pr30132.c
new file mode 100644
index 000000000000..adffae7729cb
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/compile/pr30132.c
@@ -0,0 +1,5 @@
+double testit(double _Complex* t)
+{
+  return *t==0.0?0.0:-*t;
+}
+