From: Michael Brown Date: Tue, 29 Mar 2011 23:33:48 +0000 (+0100) Subject: [forcedeth] Never change the NVREG_TRANSMITPOLL_MAC_ADDR_REV flag X-Git-Tag: v1.20.1~2174 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3e20868483ed6ef41316bd5aa52543c3ccecb3d;p=thirdparty%2Fipxe.git [forcedeth] Never change the NVREG_TRANSMITPOLL_MAC_ADDR_REV flag iPXE operates the forcedeth NIC in promiscuous mode, and never changes the unicast MAC address filter registers. We should not therefore set the flag indicating (to other drivers loaded later) that the MAC address order has already been corrected. Reported-by: Tal Aloni Tested-by: Tal Aloni Signed-off-by: Michael Brown --- diff --git a/src/drivers/net/forcedeth.c b/src/drivers/net/forcedeth.c index bb3d68447..c34a42961 100644 --- a/src/drivers/net/forcedeth.c +++ b/src/drivers/net/forcedeth.c @@ -1098,11 +1098,6 @@ nv_setup_mac_addr ( struct forcedeth_private *priv ) dev->hw_addr[3] = ( orig_mac[0] >> 16 ) & 0xff; dev->hw_addr[4] = ( orig_mac[0] >> 8 ) & 0xff; dev->hw_addr[5] = ( orig_mac[0] >> 0 ) & 0xff; - - writel ( txreg | NVREG_TRANSMITPOLL_MAC_ADDR_REV, - ioaddr + NvRegTransmitPoll ); - - DBG ( "set workaround bit for reversed mac addr\n" ); } if ( ! is_valid_ether_addr ( dev->hw_addr ) )