From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 12 Feb 2024 08:30:34 +0000 (+0200)
Subject: lib-index: Remove obsolete FIXMEs about upcoming sync lock removal
X-Git-Tag: 2.4.2~70
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3f214f46618ca1396c3b2817cfc82c3b616d5d6;p=thirdparty%2Fdovecot%2Fcore.git

lib-index: Remove obsolete FIXMEs about upcoming sync lock removal

That is never going to happen.
---

diff --git a/src/lib-index/mail-index-sync-update.c b/src/lib-index/mail-index-sync-update.c
index 622e6ab747..16ea5aa088 100644
--- a/src/lib-index/mail-index-sync-update.c
+++ b/src/lib-index/mail-index-sync-update.c
@@ -1002,11 +1002,6 @@ int mail_index_sync_map(struct mail_index_map **_map,
 	}
 	map = NULL;
 
-	/* FIXME: when transaction sync lock is removed, we'll need to handle
-	   the case when a transaction is committed while mailbox is being
-	   synced ([synced transactions][new transaction][ext transaction]).
-	   this means int_offset contains [synced] and ext_offset contains
-	   all */
 	while ((ret = mail_transaction_log_view_next(view->log_view, &thdr,
 						     &tdata)) > 0) {
 		mail_transaction_log_view_get_prev_pos(view->log_view,
diff --git a/src/lib-index/mail-transaction-log-append.c b/src/lib-index/mail-transaction-log-append.c
index 7ed2984deb..429296bcc0 100644
--- a/src/lib-index/mail-transaction-log-append.c
+++ b/src/lib-index/mail-transaction-log-append.c
@@ -143,10 +143,6 @@ log_append_sync_offset_if_needed(struct mail_transaction_log_append_ctx *ctx)
 			return;
 		}
 
-		/* FIXME: when we remove exclusive log locking, we
-		   can't rely on this. then write non-changed offset + check
-		   real offset + rewrite the new offset if other transactions
-		   weren't written in the middle */
 		offset = file->max_tail_offset + ctx->output->used +
 			sizeof(*hdr) + sizeof(*u) + sizeof(offset);
 		ctx->sync_includes_this = TRUE;