From: Hugo Landau <hlandau@openssl.org>
Date: Tue, 6 Jun 2023 15:25:10 +0000 (+0100)
Subject: QUIC: Note that we do not retransmit stream data for retransmitted streams
X-Git-Tag: openssl-3.2.0-alpha1~456
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c407d5e568ee0755d0c96c09a832af9760349c00;p=thirdparty%2Fopenssl.git

QUIC: Note that we do not retransmit stream data for retransmitted streams

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21135)
---

diff --git a/ssl/quic/quic_fifd.c b/ssl/quic/quic_fifd.c
index 8eca7520df2..e5ebc14adc7 100644
--- a/ssl/quic/quic_fifd.c
+++ b/ssl/quic/quic_fifd.c
@@ -124,6 +124,12 @@ static void on_lost(void *arg)
         sstream_updated = 0;
 
         if (chunks[i].end >= chunks[i].start) {
+            /*
+             * Note: If the stream is being reset, we do not need to retransmit
+             * old data as this is pointless. In this case this will be handled
+             * by (sstream == NULL) above as the QSM will free the QUIC_SSTREAM
+             * and our call to get_sstream_by_id above will return NULL.
+             */
             ossl_quic_sstream_mark_lost(sstream,
                                         chunks[i].start, chunks[i].end);
             sstream_updated = 1;