From: Volker Lendecke <vl@samba.org>
Date: Tue, 14 May 2024 15:01:40 +0000 (+0200)
Subject: smbd: Remove an obsolete comment
X-Git-Tag: tdb-1.4.11~688
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c422002ce5ef8ea4dcac69b7167dcf67d5c373d1;p=thirdparty%2Fsamba.git

smbd: Remove an obsolete comment

notify_fname only sends a message to the notify daemon. There is no
potential deadlock anymore.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/close.c b/source3/smbd/close.c
index 7c5c4d68bee..90c28158322 100644
--- a/source3/smbd/close.c
+++ b/source3/smbd/close.c
@@ -633,17 +633,6 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
 	}
 
 	if (lck_state.delete_object) {
-		/*
-		 * Do the notification after we released the share
-		 * mode lock. Inside notify_fname we take out another
-		 * tdb lock. With ctdb also accessing our databases,
-		 * this can lead to deadlocks. Putting this notify
-		 * after the TALLOC_FREE(lck) above we avoid locking
-		 * two records simultaneously. Notifies are async and
-		 * informational only, so calling the notify_fname
-		 * without holding the share mode lock should not do
-		 * any harm.
-		 */
 		notify_fname(conn, NOTIFY_ACTION_REMOVED,
 			     FILE_NOTIFY_CHANGE_FILE_NAME,
 			     fsp->fsp_name->base_name);