From: Karel Zak <kzak@redhat.com>
Date: Tue, 31 Jan 2012 11:55:36 +0000 (+0100)
Subject: libblkid: check rename() return value [coverity scan]
X-Git-Tag: v2.21-rc2~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c461b8d8c4d6848e00fb991d75cb53927876e964;p=thirdparty%2Futil-linux.git

libblkid: check rename() return value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/libblkid/src/save.c b/libblkid/src/save.c
index 7673ab42e7..9c1ab467ea 100644
--- a/libblkid/src/save.c
+++ b/libblkid/src/save.c
@@ -162,9 +162,15 @@ int blkid_flush_cache(blkid_cache cache)
 				}
 				free(backup);
 			}
-			rename(opened, filename);
-			DBG(DEBUG_SAVE,
-			    printf("moved temp cache %s\n", opened));
+			if (rename(opened, filename)) {
+				ret = errno;
+				DBG(DEBUG_SAVE,
+					printf("can't rename %s to %s\n",
+						opened, filename));
+			} else {
+				DBG(DEBUG_SAVE,
+				    printf("moved temp cache %s\n", opened));
+			}
 		}
 	}