From: Eliad Peller Date: Thu, 17 Jul 2014 12:00:56 +0000 (+0300) Subject: cfg80211: fix mic_failure tracing X-Git-Tag: v3.15.9~34 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c479a8748ab69398fc0587d9ee575c5d0431cef4;p=thirdparty%2Fkernel%2Fstable.git cfg80211: fix mic_failure tracing commit 8c26d458394be44e135d1c6bd4557e1c4e1a0535 upstream. tsc can be NULL (mac80211 currently always passes NULL), resulting in NULL-dereference. check before copying it. Signed-off-by: Eliad Peller Signed-off-by: Emmanuel Grumbach Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/wireless/trace.h b/net/wireless/trace.h index aabccf13e07b6..0a46eba04a4a1 100644 --- a/net/wireless/trace.h +++ b/net/wireless/trace.h @@ -2072,7 +2072,8 @@ TRACE_EVENT(cfg80211_michael_mic_failure, MAC_ASSIGN(addr, addr); __entry->key_type = key_type; __entry->key_id = key_id; - memcpy(__entry->tsc, tsc, 6); + if (tsc) + memcpy(__entry->tsc, tsc, 6); ), TP_printk(NETDEV_PR_FMT ", " MAC_PR_FMT ", key type: %d, key id: %d, tsc: %pm", NETDEV_PR_ARG, MAC_PR_ARG(addr), __entry->key_type,