From: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Date: Tue, 31 Mar 2009 02:05:26 +0000 (+0900)
Subject: Add free() call for error handling.
X-Git-Tag: v0.34~69
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c47ee042c61d050b70e6b90aa50848d82e77b041;p=thirdparty%2Flibcgroup.git

Add free() call for error handling.

I reviewed the libcgroup code in the viewpoint of memory-leak and
found a lack of free(). This patch adds a free() call for error
handling.

Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
---

diff --git a/src/api.c b/src/api.c
index d31cf4d5..2d57351f 100644
--- a/src/api.c
+++ b/src/api.c
@@ -590,8 +590,8 @@ int cgroup_init()
 		ret = ECGOTHER;
 		goto unlock_exit;
 	}
-	buf = fgets(buf, FILENAME_MAX, proc_cgroup);
-	if (!buf) {
+	if (!fgets(buf, FILENAME_MAX, proc_cgroup)) {
+		free(buf);
 		last_errno = errno;
 		ret = ECGOTHER;
 		goto unlock_exit;