From: Ondřej Surý <ondrej@isc.org>
Date: Mon, 24 Feb 2025 22:24:51 +0000 (+0000)
Subject: fix: dev: Acquire the database reference before possibly last node release
X-Git-Tag: ondrej/lock-free-qpzone-reads-v1~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c4868b5bd94a80138369752907ceb8f7230ecb9e;p=thirdparty%2Fbind9.git

fix: dev: Acquire the database reference before possibly last node release

Acquire the database reference in the detachnode() to prevent the last
reference to be release while the NODE_LOCK being locked.  The NODE_LOCK
is locked/unlocked inside the RCU critical section, thus it is most
probably this should not pose a problem as the database uses call_rcu
memory reclamation, but this it is still safer to acquire the reference
before releasing the node.

Closes #5194

Merge branch '5194-fix-assertion-failure-while-reference-counting-qpdb' into 'main'

See merge request isc-projects/bind9!10155
---

c4868b5bd94a80138369752907ceb8f7230ecb9e